Skip to content

feat(resume-dialog): remove the always-visible agent picker and hint - #593

Merged
danshapiro merged 1 commit into
mainfrom
feat/resume-dialog-simplify
Aug 1, 2026
Merged

feat(resume-dialog): remove the always-visible agent picker and hint#593
danshapiro merged 1 commit into
mainfrom
feat/resume-dialog-simplify

Conversation

@danshapiro

Copy link
Copy Markdown
Owner

Summary

  • UX simplification, user-directed (kata 1ffd): the Resume dialog's always-visible Agent dropdown and its "Unverified guess — the session store decides the agent." hint confused users — the picker was ignored whenever a match was found (the matched session's own provider wins, by design) and only took effect on the no-match "Resume anyway" path.
  • Removed both the dropdown and the hint. The parse-derived guess still drives the no-match escape hatch, whose button text remains the sole (and sufficient) disclosure: "Resume anyway with ". Pasting a command form (e.g. claude resume <id>) still steers the guess.
  • Deleted dead agentTouched state.

Test plan

  • RED-first removal test written before the change
  • Resume dialog suite: 25/25 passing
  • Sidebar suites: 160/160 passing
  • e2e resume-button: 3/3 on legacy-chromium AND rust-chromium (spec never referenced the picker — it proves agent correctness via spawned argv)
  • Typecheck clean
  • Lint parity with main

Generated with Amplifier

Outright removal, per user decision: the Agent dropdown and its
"Unverified guess" hint paragraph are gone from ResumeSessionDialog.
The parse-derived hint still drives the internal agent guess, and that
guess now surfaces ONLY on the no-match escape hatch's "Resume anyway
with {agent}" button — the guess drives, the button discloses, and the
command form (e.g. "codex resume <id>") steers it. With no user-facing
control left to set it, the agentTouched state is removed and the
advisory prefill effect simplified.

Tests: picker/hint removal assertions; parse-hint-driven disclosure on
the escape hatch (v4 id shape -> claude; "codex resume <id>" -> codex);
server-evidence-wins and degraded/no-match guards unchanged.

🤖 Generated with [Amplifier](https://github.com/microsoft/amplifier)

Co-Authored-By: Amplifier <[email protected]>
@danshapiro
danshapiro merged commit ea0e8fc into main Aug 1, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant